Skip to content

Commit

Permalink
[css-typed-om] Add support for marker properties.
Browse files Browse the repository at this point in the history
This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type <url>, but because it's not
spec'd yet, we can't really test it.

Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#546645}
  • Loading branch information
darrnshn authored and foolip committed Mar 29, 2018
1 parent 9c86b93 commit 604d17e
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
27 changes: 27 additions & 0 deletions css/css-typed-om/the-stylepropertymap/properties/marker.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<!doctype html>
<meta charset="utf-8">
<title>'marker-*' properties</title>
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-get">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-set">
<link rel="help" href="https://drafts.css-houdini.org/css-typed-om-1/#property-stle-value-normalization">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../../resources/testhelper.js"></script>
<script src="resources/testsuite.js"></script>
<body>
<div id="log"></div>
<script>
'use strict';

runUnsupportedPropertyTests('marker', [
'none', 'url(#m1)'
]);

for (const suffix of ['start', 'mid', 'end']) {
runPropertyTests(`marker-${suffix}`, [
{ syntax: 'none' },
{ syntax: '<url>' },
]);
}

</script>
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,13 @@ const gTestSyntaxExamples = {
}
],
},
'<url>': {
description: 'a URL',
examples: [
// TODO(https://github.com/w3c/css-houdini-drafts/issues/716):
// We can't test this until CSSURLValue is spec'd.
],
},
'<transform>': {
description: 'a transform',
examples: [
Expand Down

0 comments on commit 604d17e

Please sign in to comment.