Skip to content

Commit

Permalink
Remove timeout from async_test for argument form. (#14273)
Browse files Browse the repository at this point in the history 
There're cases that the timeout is passing to async_test in the tests.
They should be removed as well.
Related: #11120
  • Loading branch information
@qiuzhong @foolip
qiuzhong authored and foolip committed Nov 29, 2018
1 parent f1be712 commit 6911a29
Show file tree
Hide file tree
Showing 36 changed files with 50 additions and 79 deletions.
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/keyboard/regions-keyboard-events-001.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<script type="text/javascript">
if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand Down
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/keyboard/regions-keyboard-events-002.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield outside region");
test1.step( function() {
var testTarget = document.getElementById("outside-region");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-003.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeypress event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeypress event fired in textfield inside region");
test1.step( function() {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeypress = test1.step_func(function (evt) {
Expand All @@ -59,7 +59,7 @@
keyDown("textfield-inside");
});

var test2 = async_test("onkeypress event fired in textfield outside region", {timeout: testTimeout});
var test2 = async_test("onkeypress event fired in textfield outside region");
test2.step( function() {
var testTarget = document.getElementById("outside-region");
testTarget.onkeypress = test2.step_func(function (evt) {
Expand Down
8 changes: 4 additions & 4 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-004.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -59,7 +59,7 @@
});
});

var test2 = async_test("onkeyup event fired in textfield inside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textfield inside region");
test2.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -74,7 +74,7 @@
keyDown("textfield-inside");
});

var test3 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textfield outside region");
test3.step( function() {
var testTarget = document.getElementById("outside-region");
testTarget.onkeydown = test3.step_func(function (evt) {
Expand All @@ -88,7 +88,7 @@
});
});

var test4 = async_test("onkeyup event fired in textfield outside region", {timeout: testTimeout});
var test4 = async_test("onkeyup event fired in textfield outside region");
test4.step( function() {
var testTarget = document.getElementById("outside-region");
testTarget.onkeyup = test4.step_func(function (evt) {
Expand Down
6 changes: 3 additions & 3 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-005.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield outside region");
test1.step( function() {
var testTarget = document.getElementById("textfield-outside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -66,7 +66,7 @@
});
});

var test2 = async_test("onkeyup event fired in textarea outside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textarea outside region");
test2.step(function () {
var testTarget = document.getElementById("textarea-outside");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -80,7 +80,7 @@
});
});

var test3 = async_test("onkeydown event fired in textarea outside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textarea outside region");
test3.step( function() {
var testTarget = document.getElementById("textarea-outside");
testTarget.onkeydown = test3.step_func( function(evt) {
Expand Down
8 changes: 4 additions & 4 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-006.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -63,7 +63,7 @@
});
});

var test2 = async_test("onkeyup event fired in textfield inside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textfield inside region");
test2.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -78,7 +78,7 @@
pressDeleteKey("textfield-inside");
});

var test3 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textfield outside region");
test3.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onkeydown = test3.step_func(function (evt) {
Expand All @@ -92,7 +92,7 @@
});
});

var test4 = async_test("onkeyup event fired in textfield outside region", {timeout: testTimeout});
var test4 = async_test("onkeyup event fired in textfield outside region");
test4.step( function() {
var testTarget = document.getElementById("outside-region");
testTarget.onkeyup = test4.step_func(function (evt) {
Expand Down
10 changes: 5 additions & 5 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-007.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield1 inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield1 inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside1");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -66,7 +66,7 @@
});
});

var test2 = async_test("onkeyup event fired in textfield2 inside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textfield2 inside region");
test2.step(function () {
var testTarget = document.getElementById("textfield-inside2");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -77,7 +77,7 @@
});
});

var test3 = async_test("onkeydown event fired in textfield2 inside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textfield2 inside region");
test3.step( function() {
var testTarget = document.getElementById("textfield-inside2");
testTarget.onkeydown = test3.step_func(function (evt) {
Expand All @@ -96,7 +96,7 @@
});
});

var test4 = async_test("onkeyup event fired in textarea inside region", {timeout: testTimeout});
var test4 = async_test("onkeyup event fired in textarea inside region");
test4.step( function() {
var testTarget = document.getElementById("textarea-inside");
testTarget.onkeyup = test4.step_func(function (evt) {
Expand All @@ -110,7 +110,7 @@
});
});

var test5 = async_test("onkeydown event fired in textarea inside region", {timeout: testTimeout});
var test5 = async_test("onkeydown event fired in textarea inside region");
test5.step( function() {
var testTarget = document.getElementById("textarea-inside");
testTarget.onkeydown = test5.step_func(function (evt) {
Expand Down
6 changes: 3 additions & 3 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-008.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -63,7 +63,7 @@
});
});

var test2 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test2 = async_test("onkeydown event fired in textfield outside region");
test2.step(function () {
var testTarget = document.getElementById("textfield-outside");
testTarget.onkeydown = test2.step_func(function (evt) {
Expand All @@ -77,7 +77,7 @@
});
});

var test3 = async_test("onkeyup event fired in textfield outside region", {timeout: testTimeout});
var test3 = async_test("onkeyup event fired in textfield outside region");
test3.step(function () {
var testTarget = document.getElementById("textfield-outside");
testTarget.onkeyup = test3.step_func(function (evt) {
Expand Down
8 changes: 4 additions & 4 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-009.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield outside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield outside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-outside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -63,7 +63,7 @@
});
});

var test2 = async_test("onkeyup event fired in textfield outside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textfield outside region");
test2.step(function () {
var testTarget = document.getElementById("textfield-outside");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -75,7 +75,7 @@
});
});

var test3 = async_test("onkeydown event fired in textarea outside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textarea outside region");
test3.step(function () {
var testTarget = document.getElementById("textarea-outside");
testTarget.onkeydown = test3.step_func(function (evt) {
Expand All @@ -89,7 +89,7 @@
});
});

var test4 = async_test("onkeyup event fired in textarea outside region", {timeout: testTimeout});
var test4 = async_test("onkeyup event fired in textarea outside region");
test4.step( function() {
var testTarget = document.getElementById("textarea-outside");
testTarget.onkeyup = test4.step_func(function (evt) {
Expand Down
6 changes: 3 additions & 3 deletions css/css-regions/interactivity/keyboard/regions-keyboard-events-010.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

if(getLeftPosition("target-block") !== 0) {

var test1 = async_test("onkeydown event fired in textfield inside region", {timeout: testTimeout});
var test1 = async_test("onkeydown event fired in textfield inside region");
test1.step(function () {
var testTarget = document.getElementById("textfield-inside");
testTarget.onkeydown = test1.step_func(function (evt) {
Expand All @@ -63,7 +63,7 @@
});
});

var test2 = async_test("onkeyup event fired in textarea inside region", {timeout: testTimeout});
var test2 = async_test("onkeyup event fired in textarea inside region");
test2.step(function () {
var testTarget = document.getElementById("textarea-inside");
testTarget.onkeyup = test2.step_func(function (evt) {
Expand All @@ -77,7 +77,7 @@
});
});

var test3 = async_test("onkeydown event fired in textarea inside region", {timeout: testTimeout});
var test3 = async_test("onkeydown event fired in textarea inside region");
test3.step( function() {
var testTarget = document.getElementById("textarea-inside");
testTarget.onkeydown = test3.step_func(function (evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/mouse/regions-mouse-events-001.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onclick event fired inside region", {timeout: testTimeout});
var test1 = async_test("onclick event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onclick = test1.step_func(function (evt) {
Expand All @@ -46,7 +46,7 @@
mouseClick("target-block");
});

var test2 = async_test("onclick event fired outside region", {timeout: testTimeout});
var test2 = async_test("onclick event fired outside region");
test2.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onclick = test2.step_func(function (evt) {
Expand Down
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/mouse/regions-mouse-events-002.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmousedown event fired inside region", {timeout: testTimeout});
var test1 = async_test("onmousedown event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onmousedown = test1.step_func(function (evt) {
Expand Down
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/mouse/regions-mouse-events-003.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmousedown event fired outside region", {timeout: testTimeout});
var test1 = async_test("onmousedown event fired outside region");
test1.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onmousedown = test1.step_func(function (evt) {
Expand Down
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/mouse/regions-mouse-events-004.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmouseup event fired inside region", {timeout: testTimeout});
var test1 = async_test("onmouseup event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onmouseup = test1.step_func(function (evt) {
Expand Down
2 changes: 1 addition & 1 deletion css/css-regions/interactivity/mouse/regions-mouse-events-005.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmouseup event fired outside region", {timeout: testTimeout});
var test1 = async_test("onmouseup event fired outside region");
test1.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onmouseup = test1.step_func(function (evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/mouse/regions-mouse-events-006.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("ondblclick event fired inside region", {timeout: testTimeout});
var test1 = async_test("ondblclick event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.ondblclick = test1.step_func(function (evt) {
Expand All @@ -46,7 +46,7 @@
mouseDblClick("target-block");
});

var test2 = async_test("ondblclick event fired outside region", {timeout: testTimeout});
var test2 = async_test("ondblclick event fired outside region");
test2.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.ondblclick = test2.step_func( function(evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/mouse/regions-mouse-events-007.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmousemove event fired inside region", {timeout: testTimeout});
var test1 = async_test("onmousemove event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onmousemove = test1.step_func(function (evt) {
Expand All @@ -46,7 +46,7 @@
mouseMove("target-block");
});

var test2 = async_test("onmousemove event fired outside region", {timeout: testTimeout});
var test2 = async_test("onmousemove event fired outside region");
test2.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onmousemove = test2.step_func(function (evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/mouse/regions-mouse-events-008.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmouseover event fired inside region", {timeout: testTimeout});
var test1 = async_test("onmouseover event fired inside region");
test1.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onmouseover = test1.step_func(function (evt) {
Expand All @@ -46,7 +46,7 @@
mouseOver("target-block");
});

var test2 = async_test("onmouseout event fired inside region", {timeout: testTimeout});
var test2 = async_test("onmouseout event fired inside region");
test2.step(function () {
var testTarget = document.getElementById("target-block");
testTarget.onmouseout = test2.step_func(function (evt) {
Expand Down
4 changes: 2 additions & 2 deletions css/css-regions/interactivity/mouse/regions-mouse-events-009.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<script type="text/javascript">

if(getLeftPosition("target-block") !== 0) {
var test1 = async_test("onmouseover event fired outside region", {timeout: testTimeout});
var test1 = async_test("onmouseover event fired outside region");
test1.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onmouseover = test1.step_func(function (evt) {
Expand All @@ -46,7 +46,7 @@
mouseOver("outside-region");
});

var test2 = async_test("onmouseout event fired outside region", {timeout: testTimeout});
var test2 = async_test("onmouseout event fired outside region");
test2.step(function () {
var testTarget = document.getElementById("outside-region");
testTarget.onmouseout = test2.step_func(function (evt) {
Expand Down
Loading

0 comments on commit 6911a29

Please sign in to comment.