Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
TimothyGu committed Aug 14, 2018
1 parent c46b67f commit 7d4d95f
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ async_test(t => {
frame.contentWindow.onbeforeunload = t.unreached_func("beforeunload should not be fired");
frame.contentDocument.open();
t.step_timeout(t.step_func_done(() => {
frame.contentDocument.close();
// If the beforeunload event has still not fired by this point, we
// consider the test a success. `frame.remove()` above will allow the
// `load` event to be fired on the top-level Window.
}), 500);
});
}, "document.open() and the beforeunload event");
}, "document.open() should not fire a beforeunload event");

0 comments on commit 7d4d95f

Please sign in to comment.