Skip to content

Commit

Permalink
Updating tests for Window onerror is not triggered bug fix.
Browse files Browse the repository at this point in the history
Chromium starts propagating errors from worker's onerror to window's onerror
after https://chromium-review.googlesource.com/c/chromium/src/+/1287208,
resulting in test failures for mixed-content/module-data-worker-import
tests that do not account for the thrown exception being sent to the window.

This CL adds preventDefault() to the worker.onerror() to handle the case of
uncaught exceptions.

Strictly speaking, this is not necessary according to the current spec, as
"worker's error event" fired at Step 12.1 of #run-a-worker
https://html.spec.whatwg.org/multipage/workers.html#run-a-worker
does not cause "report the error" and thus window's onerror.
But whether window.onerror is fired or not is not what the mixed-content tests
aim to test.

Change-Id: I571aaa85d90b5f933b6212691dcc783579b294be
Reviewed-on: https://chromium-review.googlesource.com/c/1294535
Commit-Queue: Katie Dillon <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#602207}
  • Loading branch information
kjd564 authored and chromium-wpt-export-bot committed Oct 24, 2018
1 parent 6f338ac commit a2b2b90
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions mixed-content/generic/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ function bindEvents(element, resolveEventName, rejectEventName) {
resolve(e);
});
element.addEventListener(rejectEventName || "error", function(e) {
// Chromium starts propagating errors from worker.onerror to
// window.onerror. This handles the uncaught exceptions in tests.
e.preventDefault();
reject(e);
});
});
Expand Down

0 comments on commit a2b2b90

Please sign in to comment.