Audio/Orientation/Portals: use Wasm to get a SharedArrayBuffer instance

For #22358.
web-platform-tests · Mar 24, 2020 · a9b1735 · a9b1735
1 parent 4e83bff
commit a9b1735
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/orientation-sensor/orientation-sensor-tests.js b/orientation-sensor/orientation-sensor-tests.js
@@ -42,7 +42,9 @@ async function checkPopulateMatrix(t, sensorProvider, sensorType) {
 
   // Throws if passed SharedArrayBuffer view.
   assert_throws_js(TypeError,
-      () => sensor.populateMatrix(new Float32Array(new SharedArrayBuffer(16))));
+      // See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
+      // WebAssembly.Memory's size is in multiples of 64 KiB
+      () => sensor.populateMatrix(new Float32Array(new WebAssembly.Memory({ shared:true, initial:1, maximum:1 }).buffer)));
 
   sensor.start();
 

diff --git a/portals/portal-activate-data.html b/portals/portal-activate-data.html
@@ -74,7 +74,8 @@
   const w = await openBlankPortalHost();
   await promise_rejects_dom(
       t, 'DataCloneError', w.DOMException,
-      openPortalAndActivate('', {data: new SharedArrayBuffer}, w));
+      // See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
+      openPortalAndActivate('', {data: new WebAssembly.Memory({ shared:true, initial:1, maximum:1 }).buffer}, w));
 }, "A SharedArrayBuffer cannot be passed through activate data.");
 
 promise_test(async t => {

diff --git a/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html b/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html
@@ -149,7 +149,9 @@
           buffer.copyFromChannel(x, 3);
         }, '7: buffer.copyFromChannel(x, 3)').throw(DOMException, 'IndexSizeError');
 
-        let shared_buffer = new Float32Array(new SharedArrayBuffer(32));
+        // See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
+        // WebAssembly.Memory's size is in multiples of 64 KiB
+        const shared_buffer = new Float32Array(new WebAssembly.Memory({ shared:true, initial:1, maximum:1 }).buffer);
         should(
             () => {
               buffer.copyFromChannel(shared_buffer, 0);
@@ -202,7 +204,9 @@
           buffer.copyToChannel(x, 3);
         }, '6: buffer.copyToChannel(x, 3)').throw(DOMException, 'IndexSizeError');
 
-        let shared_buffer = new Float32Array(new SharedArrayBuffer(32));
+        // See https://github.com/whatwg/html/issues/5380 for why not `new SharedArrayBuffer()`
+        // WebAssembly.Memory's size is in multiples of 64 KiB
+        const shared_buffer = new Float32Array(new WebAssembly.Memory({ shared:true, initial:1, maximum:1 }).buffer);
         should(
             () => {
               buffer.copyToChannel(shared_buffer, 0);