Address review comments

web-platform-tests · Jan 26, 2021 · bc798de · bc798de
1 parent 1b9ffbb
commit bc798de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/html/cross-origin-embedder-policy/resources/shared-worker-fetch.js.py b/html/cross-origin-embedder-policy/resources/shared-worker-fetch.js.py
@@ -1,4 +1,4 @@
-body = '''
+body = b'''
 'use strict';
 
 onconnect = (event) => {
@@ -16,9 +16,9 @@
 };'''
 
 def main(request, response):
-    headers = [('Content-Type', 'text/html')]
+    headers = [(b'Content-Type', b'text/javascript')]
 
-    for value in request.GET.get_list('value'):
-        headers.append(('Cross-Origin-Embedder-Policy', value))
+    for value in request.GET.get_list(b'value'):
+        headers.append((b'Cross-Origin-Embedder-Policy', value))
 
     return (200, headers, body)
diff --git a/html/cross-origin-embedder-policy/shared-workers.html b/html/cross-origin-embedder-policy/shared-workers.html
@@ -48,9 +48,6 @@
       document.body.appendChild(iframe);
       t.add_cleanup(() => iframe.remove());
       iframe.onload = () => resolve(iframe);
-      iframe.onerror = () => {
-        reject(new Error('failed to load frame at ' + iframe.src));
-      };
     })
     .then((iframe) => {
       const sw = new iframe.contentWindow.SharedWorker(workerUrl);