Require ::picker(select) appearance:base-select opt-in

This patch requires that not only appearance:base-select be applied to <select> to make the popup be a popover, but also for appearance:base-select to be applied to select::picker(select). This is being discussed here: w3c/csswg-drafts#10440 Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819694 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350885}
web-platform-tests · Sep 4, 2024 · c8fad8c · c8fad8c
1 parent a154121
commit c8fad8c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 6 deletions.
diff --git a/...he-select-element/stylable-select/select-accessibility-minimum-target-size.tentative.html b/...he-select-element/stylable-select/select-accessibility-minimum-target-size.tentative.html
@@ -7,7 +7,13 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:base-select">
+<style>
+select, select::picker(select) {
+  appearance: base-select;
+}
+</style>
+
+<select>
   <option></option>
 </select>
 

diff --git a/...rms/the-select-element/stylable-select/select-fallback-datalist-animations.tentative.html b/...rms/the-select-element/stylable-select/select-fallback-datalist-animations.tentative.html
@@ -8,7 +8,7 @@
 <script src="/resources/testdriver-vendor.js"></script>
 
 <style>
-select {
+select, select::picker(select) {
   appearance: base-select;
 }
 

diff --git a/...emantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html b/...emantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html
@@ -11,7 +11,7 @@
 <script src="/resources/testdriver-actions.js"></script>
 
 <style>
-select {
+select, select::picker(select) {
   appearance: base-select;
 }
 </style>

diff --git a/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html
@@ -10,7 +10,7 @@
 <script src="/resources/testdriver-actions.js"></script>
 
 <style>
-select {
+select, select::picker(select) {
   appearance: base-select;
 }
 </style>

diff --git a/...antics/forms/the-select-element/stylable-select/select-option-hover-styles.tentative.html b/...antics/forms/the-select-element/stylable-select/select-option-hover-styles.tentative.html
@@ -12,10 +12,13 @@
   color: SelectedItemText;
   background-color: SelectedItem;
 }
+select, select::picker(select) {
+  appearance: base-select;
+}
 </style>
 <div id=selecteditem>SelectedItem test colors</div>
 
-<select style="appearance:base-select">
+<select>
   <option class=one>one</option>
   <option class=two>two</option>
   <option class=three disabled>disabled</option>

diff --git a/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html b/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html
@@ -6,8 +6,14 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
+<style>
+select, select::picker(select) {
+  appearance: base-select;
+}
+</style>
+
 <form>
-  <select style="appearance:base-select">
+  <select>
     <button>
       <selectedoption></selectedoption>
     </button>