[css-flexbox] Apply min-height: auto to nested flexboxes again

This was made possible by crrev.com/c/1283482, which avoids the performance and correctness issues this previously caused. This relands crrev.com/c/1246730 / crrev.com/c/1252682. The ChromeOS UI breakage was fixed by crrev.com/c/1281726 and crrev.com/c/1282462 IF THIS BREAKS ANY FURTHER CHROME UI: Please don't revert this patch; instead, add min-height: 0 to any inner nested flexboxes that may be affected by this patch. This is an important change for web interop with the other browsers. Bug: 596743 Change-Id: I9afe54dce82d41da452d1fdca8150ca22ebb6f9c Reviewed-on: https://chromium-review.googlesource.com/c/1269235 Commit-Queue: Christian Biesinger <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/master@{#601540}
web-platform-tests · Oct 22, 2018 · dffb313 · dffb313
1 parent 40e9266
commit dffb313
Showing 1 changed file with 49 additions and 0 deletions.
diff --git a/css/css-flexbox/flex-minimum-height-flex-items-011.xht b/css/css-flexbox/flex-minimum-height-flex-items-011.xht
@@ -0,0 +1,49 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml">
+    <head>
+        <title>CSS Flexible Box Test: Minimum height of flex items</title>
+        <link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]" />
+        <link rel="help" href="http://www.w3.org/TR/css-flexbox-1/#min-size-auto" title="4.5. Implied Minimum Size of Flex Items" />
+        <link rel="match" href="../reference/ref-filled-green-100px-square.xht" />
+        <meta name="assert" content="Checks that minimum height for flex items is the min-content size." />
+        <style type="text/css"><![CDATA[
+            #reference-overlapped-red {
+                position: absolute;
+                background-color: red;
+                width: 100px;
+                height: 100px;
+                z-index: -1;
+            }
+
+            #constrained-flex {
+                display: flex;
+                flex-direction: column;
+                width: 100px;
+                height: 10px;
+            }
+
+            #test-flex-item-overlapping-green {
+                display: flex;
+                flex-basis: 0;
+                color: green;
+                background-color: green;
+                font: 50px/1 Ahem;
+            }
+
+            #content-100x100 {
+                width: 100px;
+                height: 100px;
+            }
+        ]]></style>
+    </head>
+    <body>
+        <p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+
+        <div id="reference-overlapped-red"></div>
+        <div id="constrained-flex">
+            <div id="test-flex-item-overlapping-green">
+                <div id="content-100x100"></div>
+            </div>
+        </div>
+    </body>
+</html>