Skip to content

Commit

Permalink
Modify the UA stylesheet to allow <dialog popup>
Browse files Browse the repository at this point in the history
This CL does two main things:
 1. Convert the :-internal-popup-hidden to
    :-internal-popup-opening-or-open
 2. Add/modify rules for both dialog and [popup] so that they don't
    add display:none when a <dialog popup> is either open as a
    dialog or pop-up.

See this issue for details:
   openui/open-ui#520

Bug: 1307772
Change-Id: I751f6991a988a58032cebd52f289e5468140ce79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856639
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1040576}
  • Loading branch information
mfreed7 authored and chromium-wpt-export-bot committed Aug 29, 2022
1 parent 1757d32 commit e272099
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions html/semantics/popups/popup-attribute-basic.tentative.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@
<header popup>Different element type</header>
<nav popup>Different element type</nav>
<input type=text popup value="Different element type">
<dialog popup>Dialog with popup attribute</dialog>
<dialog popup="manual">Dialog with popup=manual</dialog>
<div popup=true>Invalid popup value - defaults to popup=manual</div>
<div popup=popup>Invalid popup value - defaults to popup=manual</div>
<div popup=invalid>Invalid popup value - defaults to popup=manual</div>
</div>

<div id=nonpopups>
<div>Not a pop-up</div>
<dialog open>Dialog without popup attribute</dialog>
</div>

<div popup class=animated>Animated pop-up</div>
Expand Down

0 comments on commit e272099

Please sign in to comment.