Skip to content

Commit

Permalink
[css-grid] Some fixes on grid-container-scrollbar-* tests
Browse files Browse the repository at this point in the history
* Use Ahem font to avoid weird small pixel differences on iOS.
* Fix some typos reported by @fred-wang at https://bugs.webkit.org/show_bug.cgi?id=191656#c14
  • Loading branch information
mrego committed Nov 16, 2018
1 parent ab42c6d commit ef7824a
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<style>
.container {
font: 10px/1 Ahem;
margin: 10px;
background: grey;
}
Expand Down Expand Up @@ -32,7 +33,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down
5 changes: 3 additions & 2 deletions css/css-grid/grid-model/grid-container-scrollbar-001.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
<link rel="match" href="grid-container-scrollbar-001-ref.html">
<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<link href="support/grid.css" rel="stylesheet">
<style>
.grid {
font: 10px/1 Ahem;
margin: 10px;
}

Expand All @@ -29,7 +30,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<style>
.container {
font: 10px/1 Ahem;
margin: 10px;
background: grey;
writing-mode: vertical-lr;
Expand Down Expand Up @@ -33,7 +34,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
<link rel="match" href="grid-container-scrollbar-vertical-lr-001-ref.html">
<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<link href="support/grid.css" rel="stylesheet">
<style>
.grid {
font: 10px/1 Ahem;
margin: 10px;
writing-mode: vertical-lr;
}
Expand All @@ -30,7 +31,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<style>
.container {
font: 10px/1 Ahem;
margin: 10px;
background: grey;
writing-mode: vertical-rl;
Expand Down Expand Up @@ -33,7 +34,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
<link rel="author" title="Manuel Rego Casasnovas" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-grid/#grid-model">
<link rel="match" href="grid-container-scrollbar-vertical-rl-001-ref.html">
<meta name="assert" content="This test verifes that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<meta name="assert" content="This test verifies that scrollbars are properly painted on grid containers, and are shown in the expected position depending on the direction.">
<link href="support/grid.css" rel="stylesheet">
<style>
.grid {
font: 10px/1 Ahem;
margin: 10px;
writing-mode: vertical-rl;
}
Expand All @@ -30,7 +31,7 @@
}
</style>

<p>The test passes if it has the same output than the reference.</p>
<p>The test passes if it has the same output as the reference.</p>

<div style="float: left; width: 350px;">

Expand Down

0 comments on commit ef7824a

Please sign in to comment.