Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test execution time to wptreport.json format #10026

Closed
jgraham opened this issue Mar 14, 2018 · 16 comments · Fixed by #11478
Closed

Add test execution time to wptreport.json format #10026

jgraham opened this issue Mar 14, 2018 · 16 comments · Fixed by #11478

Comments

@jgraham
Copy link
Contributor

jgraham commented Mar 14, 2018

This was suggested in # #9972.

Basically the execution time is the timestamp of the test_end event minus the timestamp of the test_start event. So to fix this look in tools/wptrunner/wptrunner/formatters.py, add a time field to the data and populate it with the execution time per test.

@ghost
Copy link

ghost commented Mar 14, 2018

Can I work on it?

@jgraham
Copy link
Contributor Author

jgraham commented Mar 14, 2018

Yes.

@foolip
Copy link
Member

foolip commented Mar 14, 2018

This would be great!

@marimeireles
Copy link
Member

Hey, @ManiKishan
Are you still working on this?
Thanks.

@ghost
Copy link

ghost commented Mar 22, 2018

No,sorry I would not be able to work on it now.
Sorry.

@marimeireles
Copy link
Member

I could try to fix this, if you don't mind.

@jgraham
Copy link
Contributor Author

jgraham commented Mar 22, 2018

Go for it.

@foolip
Copy link
Member

foolip commented May 9, 2018

@marimeireles do you still intend to work on this?

@marimeireles
Copy link
Member

Hey,
Not in the moment, sorry!

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jun 12, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jun 13, 2018
@foolip
Copy link
Member

foolip commented Jun 14, 2018

Oh yay, @gsnedders for president! @jugglinmike @Hexcles, have you seen this show up in runs yet? How much does it change the wptreport size?

@jugglinmike
Copy link
Contributor

Yup, the data is being collected!

$ ssh bocoup-wptd-build-master 'sudo -u wptdmaster cat /mnt/buildmaster-data/chunk-results/f556cda8f3ab2c14851a63ecd3def3c03de8182d/edge-17-windows-10-sauce/10_of_100.json | python -m json.tool | head -n 10'
{
    "results": [
        {
            "duration": 3385,
            "message": null,
            "status": "PASS",
            "subtests": [],
            "test": "/css/css-writing-modes/background-size-document-root-vrl-004.html"
        },
        {

I don't have a great way to check the size of the final reports, though, since we remove them immediately following successful upload.

@Hexcles
Copy link
Member

Hexcles commented Jun 14, 2018

I will have the numbers soon (fixing a bug in receiver now).

@jgraham
Copy link
Contributor Author

jgraham commented Jun 14, 2018

wptreport is not optimized for size, if we are concerned about non-compressed size there's definitely changes we could make. What's the motivation there?

@foolip
Copy link
Member

foolip commented Jun 14, 2018

There's a request size limit in the wpt.fyi receiver, and we're not miles away from it. Hopefully this doesn't push it over the limit.

@Hexcles
Copy link
Member

Hexcles commented Jun 14, 2018

@foolip we only transport the compressed form

Adding a field like this wouldn't blow the compressed size up too much due to the nature of dictionary-based compression algorithms.

@foolip
Copy link
Member

foolip commented Jun 14, 2018

Well, with enough precision the numbers will be increasingly random, and not compress as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants