-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test execution time to wptreport.json format #10026
Comments
Can I work on it? |
Yes. |
This would be great! |
Hey, @ManiKishan |
No,sorry I would not be able to work on it now. |
I could try to fix this, if you don't mind. |
Go for it. |
@marimeireles do you still intend to work on this? |
Hey, |
Oh yay, @gsnedders for president! @jugglinmike @Hexcles, have you seen this show up in runs yet? How much does it change the wptreport size? |
Yup, the data is being collected!
I don't have a great way to check the size of the final reports, though, since we remove them immediately following successful upload. |
I will have the numbers soon (fixing a bug in receiver now). |
wptreport is not optimized for size, if we are concerned about non-compressed size there's definitely changes we could make. What's the motivation there? |
There's a request size limit in the wpt.fyi receiver, and we're not miles away from it. Hopefully this doesn't push it over the limit. |
@foolip we only transport the compressed form Adding a field like this wouldn't blow the compressed size up too much due to the nature of dictionary-based compression algorithms. |
Well, with enough precision the numbers will be increasingly random, and not compress as well. |
This was suggested in # #9972.
Basically the execution time is the timestamp of the
test_end
event minus the timestamp of thetest_start
event. So to fix this look intools/wptrunner/wptrunner/formatters.py
, add atime
field to the data and populate it with the execution time per test.The text was updated successfully, but these errors were encountered: