-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/WebCryptoAPI/generateKey/* are disabled/flaky in Mozilla Chromium WebKit #10794
Comments
@andypaicu @foolip @Hexcles any thoughts on what, if anything, we can do with this test? The test has this warning <p>
<strong>Warning!</strong> RSA key generation is intrinsically
very slow, so the related tests can take up to
several minutes to complete, depending on browser!
</p> |
How long does it take to generate a single RSA key? Is the test just trying to generate too many and needs to be split? |
For me it seems to take around 1s per subtest, and this has 156 subtests, so yeah, splitting it up to multiple files (or |
This is also tracked in Chromium by the way: https://crbug.com/787971 Splitting the tests seems a reasonable way. Apparently |
I think it would work to use |
@Hexcles yep, my report picked that up :) |
Slow tests test 10 subtests at a time, using the `// META: variant=...` feature. Fixes #10794.
Slow tests test 10 subtests at a time, using the `// META: variant=...` feature. Fixes #10794.
Slow tests test 10 subtests at a time, using the `// META: variant=...` feature. Fixes #10794.
Slow tests test 10 subtests at a time, using the `// META: variant=...` feature. Fixes #10794.
Make sure you test this in Firefox; iirc the generation is slower in Gecko for some (I think intentional) reason. |
For me it seems slightly faster in Firefox (compared to Chrome), but of course it can depend on the device under test. If 10 subtests is still too much we can do 5 or so. But let's try 10 first. |
@Hexcles can you update TestExpectations for chromium? @cdumez can you update TestExpectations for webkit? Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1470130 for gecko. |
The two WebCryptoAPI tests have been fixed (and renamed) in upstream (web-platform-tests/wpt#10794) and we can now safely remove these two expectations. TBR=foolip No-Try: True Bug: 787971 Change-Id: I76a0c288e37ef92c30d936d76d652e65ab9d204b Reviewed-on: https://chromium-review.googlesource.com/1110738 Reviewed-by: Robert Ma <[email protected]> Commit-Queue: Robert Ma <[email protected]> Cr-Commit-Position: refs/heads/master@{#569368}
Commented in https://bugs.webkit.org/show_bug.cgi?id=182396 |
http://bocoup.github.io/wpt-disabled-tests-report/
Investigate what's up with this test:
Edit: also:
The text was updated successfully, but these errors were encountered: