-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with signal detection in RTCPeerConnection-helper.js #23340
Comments
On signal: humans are usually seen to be better able to percieve luma (brightness) than color - so codecs tend to optimize for luma fidelity. It's been suggested that instead of taking the average across the R/G/B values, we should use the ITU luma formula:
(code from https://github.com/webrtc/testrtc/blob/master/src/js/videoframechecker.js) But the easy thing to do to allay the concern is to write a test for the framework that scans through a range of "signal" values for a given and sees if it can reliably detect the changes; if there are ranges of values where detection doesn't work, we should prevent them from being used. |
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172971 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#767270}
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: web-platform-tests/wpt#23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172971 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#767270}
This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: #23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172971 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#767270}
…elper function., a=testonly Automatic update from web-platform-tests Add a test to check the video detector helper function. This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: web-platform-tests/wpt#23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172971 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#767270} -- wpt-commits: cdd4b43f2f89422f36d81546df70eb09f6aa8ed0 wpt-pr: 23341
…elper function., a=testonly Automatic update from web-platform-tests Add a test to check the video detector helper function. This also checks that the video luma settles to a reasonable value for a large range of values, so could be considered a codec test. WPT bug: web-platform-tests/wpt#23340 Bug: none Change-Id: I6ce0537b90903d823945e2fe3c5389fa4c132608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172971 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Cr-Commit-Position: refs/heads/master@{#767270} -- wpt-commits: cdd4b43f2f89422f36d81546df70eb09f6aa8ed0 wpt-pr: 23341
This issue is to track two things from #22779.
OffscreenCanvas
works, but it's not enabled in Firefox or Safari yet, so the tests will fail because of that. It's probably possible to use a canvas element instead, with a TODO to replace it later.Alternative idea for signal: send a specific color like 00FF00 green, and detect a signal if it's "almost" green. This should allow for a bigger margin without risking false detection, as long as there's nothing almost green elsewhere in the frame.
See #22779 (comment) for original discussion.
The text was updated successfully, but these errors were encountered: