idlharness.js's assert_type_is needs to be taught about each interface #23346
Assignees
Labels
Comments
|
This is similar to (but not quite the same as) #23329, in particular your reference to the built-in types like Float32Array. Note that those types aren't interfaces, though. |
|
Yeah, cc: @stephenmcgruer too |
|
That seems like a reasonable default to me; I can own landing that change. |
stephenmcgruer
added a commit
that referenced
this issue
May 25, 2020
stephenmcgruer
added a commit
that referenced
this issue
May 28, 2020
* Add default case for non-member types in assert_type_is Fixes #23346 * Update comment
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jun 1, 2020
… assert_type_is, a=testonly Automatic update from web-platform-tests Add default case for non-member types in assert_type_is (#23754) * Add default case for non-member types in assert_type_is Fixes web-platform-tests/wpt#23346 * Update comment -- wpt-commits: d94c7aa1d9d3e311043729741df287a980df296a wpt-pr: 23754
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this issue
Jun 2, 2020
… assert_type_is, a=testonly Automatic update from web-platform-tests Add default case for non-member types in assert_type_is (#23754) * Add default case for non-member types in assert_type_is Fixes web-platform-tests/wpt#23346 * Update comment -- wpt-commits: d94c7aa1d9d3e311043729741df287a980df296a wpt-pr: 23754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As noted in e.g. #23323 (comment) the idlharness assertion
assert_type_is()needs to be explicitly made aware of interfaces like Float32Array and DataView. If an interface isn't listed, it leads to unexpected failures.We likely haven't noticed this much because most idlharness tests are boilerplate and don't provide sample values. Even after the above PR, grepping for the error in blink's output, I found some geometry-related fails:
" Unrecognized type"--> DOMRect, DOMRectReadOnly, DOMPointReadOnly, DOMMatrixCan we update
assert_type_is()to havevalue instanceof self[type]as the default case? (Honest question: I didn't look deeply enough to see what the downsides are)cc: @foolip
The text was updated successfully, but these errors were encountered: