Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for WebDriver Bidi result Proxy #38567

Closed
Lightning00Blade opened this issue Feb 17, 2023 · 1 comment · Fixed by #40814
Closed

Missing tests for WebDriver Bidi result Proxy #38567

Lightning00Blade opened this issue Feb 17, 2023 · 1 comment · Fixed by #40814

Comments

@Lightning00Blade
Copy link
Contributor

While implementing BiDi in Puppeteer some of our test were not passing because of expectation for RemoteValue for Proxy to different then Object, which some browsers don't do at the moment.

WPT has test for evaluate and call_function results but some return types from the spec are not test, there are already TODOs in evaluate/result.py and call_function/result.py.
@thiagowfx
Copy link
Member

WPT additions: #40814

@thiagowfx thiagowfx mentioned this issue Jul 3, 2023
Merged
thiagowfx pushed a commit that referenced this issue Jul 3, 2023
script: add missing serialization tests: iterator, generator, proxy
62c9977 
Closes: #38567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

script: add missing serialization tests: iterator, generator, proxy web-platform-tests/wpt
2 participants
@thiagowfx @Lightning00Blade