-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wdspec] /webdriver/tests/bidi/browsing_context/reload/ is flaky in Chromium #41083
Comments
cc @thiagowfx |
I've noticed the same today and did some quick checks. The problem seems to happen only when more than one test method in that module gets run. Running each test on its own doesn't produce this failure. It seems that some unexpected content might be sent by chromedriver? This can be reproduced locally as well, but cannot tell more details because I'm not able to enable any debug/trace logs for chromedriver. |
@whimboo Do you observe the failure in Geckodriver? |
We do not have reload implemented yet. So all these tests are failing with an unknown operation error. That means I cannot test it at the moment. Are you able to reproduce it locally when running the following command with a Canary build of Chrome?
|
The problem here is most likely present because the initial navigation is not awaited for. As such the reload is started while the current page is still loading, which then can cause side-effects. I'm going to fix that on https://bugzilla.mozilla.org/show_bug.cgi?id=1830859, and I hope that this is enough here. |
Thanks for the investigation! |
FYI the updated tests will be available once #41841 has been merged. |
I made some comments there. Thanks! |
The PR has been merged now. Not sure if your wrapper already supports returning a |
Let's see: GoogleChromeLabs/chromium-bidi#1264 This version is still using |
See https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/6109757468/job/16581412407?pr=1265 and GoogleChromeLabs/chromium-bidi#1265 |
@thiagowfx please note that from the log output it is not clear why or where it is timing out. Are these both tests or maybe only the cross-origin test case? |
My understanding is: same-origin seems to be executed first (as it's listed first), and the timeout happens there already. |
Ok, so it only happens in CI and you cannot reproduce locally? If that is the case do you have a chance to somehow enable debug/trace logging for the tests? Where exactly does it hang/timeout? |
Running it locally in our mapper repo ( I am not quite sure how to debug it. I'll try. GoogleChromeLabs/chromium-bidi#1288 |
I have the impression it's not flaky anymore: GoogleChromeLabs/chromium-bidi#1288. Hope not to be speaking too soon...will reopen if it turns out to be wrong. |
See https://github.com/web-platform-tests/wpt/pull/41041/checks?check_run_id=15094630093
It appears that reload tests are flaky in Chromium.
reload.py
frame.py
The text was updated successfully, but these errors were encountered: