Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability checker should run for reference changes #5319

Closed
gsnedders opened this issue Apr 3, 2017 · 13 comments
Closed

Stability checker should run for reference changes #5319

gsnedders opened this issue Apr 3, 2017 · 13 comments

Comments

@gsnedders
Copy link
Member

cc/ @jgraham @jugglinmike

@bobholt
Copy link
Contributor

bobholt commented May 19, 2017

@gsnedders: can you elaborate on this? Sounds like it was parrt of a discussion I missed.

@gsnedders
Copy link
Member Author

Given a reftest a.html with <link rel=match href=a-ref.html>, the stability checker will run the test if there is a change to a.html, but won't run the test if there is a change to a-ref.html.

@gsnedders
Copy link
Member Author

(Of course the problem is harder than that because of the possibility of chaining references, where a-ref.html would have another <link rel=match>.)

@foolip
Copy link
Member

foolip commented Oct 4, 2017

@lukebjerring is this something you could look into as part of your work on #7475? I'm calling this roadmap on the assumption that will make sense.

@kereliuk
Copy link
Contributor

@lukebjerring any update on this?

@lukebjerring
Copy link
Contributor

No, I haven't looked at it yet, will assign to self though (it's in the pile)

@lukebjerring lukebjerring self-assigned this Oct 23, 2017
@kereliuk
Copy link
Contributor

@lukebjerring have you had a chance to look at this yet?

@lukebjerring
Copy link
Contributor

lukebjerring commented Nov 29, 2017 via email

@alijuma
Copy link
Contributor

alijuma commented Feb 13, 2018

Re-ping about an update since this has prioirty:roadmap.

@lukebjerring lukebjerring removed their assignment Feb 13, 2018
@lukebjerring
Copy link
Contributor

Dropping that label; this is a side-issue barely related to a P2 OKR.

@foolip
Copy link
Member

foolip commented May 6, 2021

@gsnedders given changes in the manifest format since this issue was filed, is this now easier to implement?

@gsnedders
Copy link
Member Author

Not sure. It's been a long time since I've touched the code that finds how we find affected tests.

@foolip
Copy link
Member

foolip commented May 7, 2021

It looks like this has been fixed actually. Here's how I tried it:

echo >> css/css-grid/table-grid-item-dynamic-001-ref.html
git commit -a -m bla
./wpt tests-affected HEAD~

That lists css/css-grid/table-grid-item-dynamic-001.html as affected!

@foolip foolip closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants