-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests relying on larger viewports #5403
Comments
Just curious, how did you get the numbers? |
@mrego a script that I thought I had on gist.github.com somewhere but seemingly not; essentially going through all reftests and reading something like the |
It'd be really nice to have it around, I realized that I was using 800x600 (that's what Chromium and WebKit use) instead of 600x600 in #9716. |
@mrego https://gist.github.com/gsnedders/6721716f6f90380ac6b76acbdbee91a2; I have no idea whether we'll standardise on 800x600 or 600x600, FWIW. |
Hey, thanks for the link. I'll give it a try at some point. So I thought 600x600 was agreed before, if not what I have seen is that Chromium an WebKit use 800x600, dunno what happens in Firefox or Edge. |
@mrego Firefox just uses wptrunner so it does use 600x600. I have no memory of what Edge does (@thejohnjansen?). |
1- So the definitive standard for tests is (should be?) 600px wide by 600px tall? Test assumptions now state:
2- A lot of tests could be retrofitted to comply with 600x600. 3- Tests that occupy more than 1000 (1 thousand) in width or height should be examined or reconsidered ... : css/CSS2/abspos/abspos-containing-block-initial-001.xht (588x10110) etc... This one |
See #7598; we're not consistent here, though the upstream maintained runners use 600x600. It seems likely that we'll change that to be larger, however.
That's definitely true. That said, there's definitely an argument as to whether it's a worthwhile use of resources to fix these tests versus other things people could work on, especially if we do change the (default) size.
From a brief glance, they're mostly either deliberately doing that or ex-Presto tests (which were 1600x1200). |
The documentation states variously that reftests are taken at 600x600 and 800x600; they're mostly run at 600x600 and this apparently matches what was decided for the CSS testsuite years ago so let's just go with that.
Note we also have a
<meta name='viewport-size'>
that's totally undocumented and that only works for Servo per w3c/wptrunner#166.This follows on from #4619 but provides a far better list of affected tests and includes the now merged CSS testsuite.
The text was updated successfully, but these errors were encountered: