[css-text] Modify reference tests so they fit in the viewport #9716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many reftests in this suite are bigger than the default viewport size that browsers use when run the tests. That means that only the first cases are checked, everything that is not in the visible area won't be compared, so differences there won't be detected. This patch modifies a bunch of tests to make them fit in the viewport. Some of the tests are splitted in several files, as they have a lot of content. Tests under folder text-transform/ still have this kind of issues, some are actually way bigger, so that would need to be fixed in a follow-up patch.
Build PASSEDStarted: 2018-02-28 16:38:37 View more information about this build on: |
|
This is part of #5403. |
kojiishi
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many reftests in this suite are bigger than the default viewport size
that browsers use when run the tests.
That means that only the first cases are checked, everything that is not
in the visible area won't be compared, so differences there won't be detected.
This patch modifies a bunch of tests to make them fit in the viewport.
Some of the tests are splitted in several files, as they have a lot of content.
Tests under folder text-transform/ still have this kind of issues,
some are actually way bigger, so that would need to be fixed
in a follow-up patch.