Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for wide Python build in build-css-testsuites.sh #5504

Closed
wpt-issue-mover opened this issue Apr 7, 2017 · 4 comments
Closed

Check for wide Python build in build-css-testsuites.sh #5504

wpt-issue-mover opened this issue Apr 7, 2017 · 4 comments
Labels
css-build-system infra priority:backlog wg-css

Comments

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#1245 by @gsnedders on 22 Mar 2017, 17:48 UTC:

At least according to https://wiki.csswg.org/test/css2.1/harness the build system needs this.
@wpt-issue-mover wpt-issue-mover mentioned this issue Apr 7, 2017
Closed
@gsnedders gsnedders self-assigned this Apr 7, 2017
@gsnedders gsnedders removed their assignment Sep 13, 2017
@foolip
Copy link
Member

foolip commented Oct 4, 2017

Since csswg-test is now merged, I assume this is no longer relevant.

@foolip foolip closed this as completed Oct 4, 2017
@gsnedders
Copy link
Member

Nah, we still have the build system here, and we probably want this for the sake of people who care about the CSS test harness.

@gsnedders gsnedders reopened this Oct 5, 2017
@gsnedders
Copy link
Member

(It's also a few lines if someone sits down and fixes it!)

qiuzhong added a commit to qiuzhong/wpt that referenced this issue Oct 24, 2018
@qiuzhong
Add UCS-4 support check for Python in build-css-testsuites.sh
00b6193 
CSS test suite build system requires Python UCS-4 support.
Add this check in css/build-css-testsuites.sh.
Fix: web-platform-tests#5504
@qiuzhong
Copy link
Contributor

If you don't mind, I'm going to fix this. I don't think it's hard to fix it. By checking if sys.maxunicode is 1114111 (0x10ffff), we can know if the Python supports UCS-4 quickly.

@qiuzhong qiuzhong mentioned this issue Oct 24, 2018
Merged
gsnedders pushed a commit that referenced this issue Oct 24, 2018
@qiuzhong @gsnedders
Add UCS-4 support check for Python in build-css-testsuites.sh (#13696)
32150f7 
CSS test suite build system requires Python UCS-4 support.

Add this check in css/build-css-testsuites.sh.

Fixes: #5504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-build-system infra priority:backlog wg-css
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gsnedders @foolip @qiuzhong @wpt-issue-mover