Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Chrome unstable" is a confusing job name #5956

Closed
annevk opened this issue May 17, 2017 · 4 comments
Closed

"Chrome unstable" is a confusing job name #5956

annevk opened this issue May 17, 2017 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented May 17, 2017

Whenever I read this I think the results are unstable in Chrome.

@annevk annevk added the infra label May 17, 2017
@bobholt
Copy link
Contributor

bobholt commented May 19, 2017

I see your point. This used to say "unstable channel", but I removed "channel" so that the Sauce tests wouldn't say "Safari channel" or "MicrosoftEdge channel."

I's an easy enough code change beyond coming up with phrasing that works for all cases, but it would require changing code in both web-platform-tests and prbuildbot and @sideshowbarker doing another simultaneous merge-and-deploy in both browsers. Is the header confusing enough that we should do that, or can it wait a couple of weeks for the single-comment functionality to wipe it away?

@annevk
Copy link
Member Author

annevk commented May 19, 2017

It can wait for sure.

@RByers
Copy link
Contributor

RByers commented Aug 16, 2017

@bobholt now that we have the single-comment system, can we fix this? I.e. instead of saying "Chrome unstable" can it either have the specific version number like Safari and Edge do or just say "Chrome dev channel"?

@RByers RByers changed the title "Chrome (unstable)" is a confusing header "Chrome unstable" is a confusing job name Aug 16, 2017
@foolip
Copy link
Member

foolip commented Jan 3, 2018

I think this name comes from JOB=stability SCRIPT=tools/ci/ci_stability.sh PRODUCT=chrome:unstable because I couldn't find the string "Chrome Unstable" anywhere in this repo or https://github.com/w3c/wpt-pullresults.

The stability job will install https://dl.google.com/linux/direct/google-chrome-unstable_current_amd64.deb, so I installed that locally to confirm it's branded as "Dev" on the icon, and "65.0.3298.3 (Official Build) dev (64-bit)" in chrome://version/. So that's really what we should call it, the package name is probably because "dev" in debian package names usually means header files etc., or some other historical reason we don't need to care about.

I think the fix should be for the install_chrome() function in tools/ci/lib.sh to also accept "dev" as an argument and map that to unstable. The "unstable" bit will only be around the package name, everything else can call it "dev".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants