-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint is failing on css/css-fonts/cascading-font-sizes.html #9304
Comments
Noticed because https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/ is failing. (It runs the lint before uploading the changes to Chromium code review.) |
It looks like there is no recent PR which brought in these changes, which would explain why Travis has not run. Trying to figure out how they ended up on master... |
Hmm, so a02f1bc is the topmost commit on master, and as a self-contained commit that seems to make sense. But its parent commit was a merge commit, a backwards one which would have results from But why was it possible to push to master accidentally? @svgeesus, are you an admin of the repo indirectly, by any chance? |
Thanks for fixing this! |
I've asked @svgeesus not to push directly to master before, as it isn't the first time he's caused lint failures that couldn't have landed had they gone through CI. :( |
Apologies for causing trouble.
Yes, that is the one I was trying to commit. I didn't ask for review because the substance of the tests had not changed (just the spec link was bumped from Fonts 3 to Fonts 4, as that section of the spec was deferred to level 4). I will do PR from now on, so that Travis CI can run. |
Added in 8e05b11 and somehow got past Travis.
The text was updated successfully, but these errors were encountered: