Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] Stub list-valued tests. #10191

Merged
merged 1 commit into from
Mar 28, 2018
Merged

[css-typed-om] Stub list-valued tests. #10191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
<script>
'use strict';

// FIXME: animation-direction is list-valued. Run list-valued tests here too.
runPropertyTests('animation-direction', [
runListValuedPropertyTests('animation-direction', [
{ syntax: 'normal' },
{ syntax: 'reverse' },
{ syntax: 'alternate-reverse' },
Expand Down
3 changes: 1 addition & 2 deletions css/css-typed-om/the-stylepropertymap/properties/background-image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
<script>
'use strict';

// FIXME: background-image is list-valued. Run list-valued tests here too.
runPropertyTests('background-image', [
runListValuedPropertyTests('background-image', [
{ syntax: 'none' },
{ syntax: '<image>' },
]);
Expand Down
3 changes: 1 addition & 2 deletions css/css-typed-om/the-stylepropertymap/properties/mask-image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
<script>
'use strict';

// FIXME: mask-image is list-valued. Run list-valued tests here too.
runPropertyTests('mask-image', [
runListValuedPropertyTests('mask-image', [
{ syntax: 'none' },
{ syntax: '<image>' },
]);
Expand Down
6 changes: 6 additions & 0 deletions css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,12 @@ function runPropertyTests(propertyName, testCases) {
}
}

// Same as runPropertyTests but for list-valued properties.
function runListValuedPropertyTests(propertyName, testCases) {
// TODO(https://crbug.com/545318): Run list-valued tests as well.
runPropertyTests(propertyName, testCases);
}

// Check that |propertyName| doesn't "support" examples in |testExamples|.
// |testExamples| is a list of CSS string values. An "unsupported" value
// doesn't have a corresponding Typed OM representation. It normalizes as
Expand Down
3 changes: 1 addition & 2 deletions css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
<script>
'use strict';

// FIXME: transition-duration is list-valued. Run list-valued tests here too.
runPropertyTests('transition-duration', [
runListValuedPropertyTests('transition-duration', [
{ syntax: '<time>' },
]);

Expand Down