Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wptrunner] Re-enable return code #10742

Merged
merged 3 commits into from
May 9, 2018
Merged

[wptrunner] Re-enable return code #10742

merged 3 commits into from
May 9, 2018

Commits on May 9, 2018

  1. [infra] Correct integration test 

    By default, "single-page tests" must include an explicit call to the
global `done` function [1]. Insert this invocation to signal completion
and avoid a test timeout when the test's expectation is satisfied.

[1] http://web-platform-tests.org/writing-tests/testharness-api.html
    @jugglinmike
    jugglinmike committed May 9, 2018
    Configuration menu
    Copy the full SHA
    8271378 View commit details
    Browse the repository at this point in the history

  2. [ci] Correct syntax in build script

    @jugglinmike
    jugglinmike committed May 9, 2018
    Configuration menu
    Copy the full SHA
    041e0ed View commit details
    Browse the repository at this point in the history

  3. [wptrunner] Allow test failures to be ignored 

    In a previous commit [1] the WPT CLI was modified to unconditionally
ignore the return value of the `wptrunner.start` method. Although this
behavior is convenient in cases where there is no expectation data, it
obscures errors that are relevant in any context.

Specifically, the `start` method returns a non-zero value when no tests
are run, but this is a reliable indicator of an erroneous configuration.
Because the `wpt run` command is used to validate the infrastructure of
the web-platform-tests project, ignoring this case allows faulty
configurations to go unnoticed [2].

Implement a new CLI option named `--no-fail-on-unexpected` to allow
users to allow test failure while still being alerted to errors that
cause zero tests to be executed. Update the script designed for the
TaskCluster service to enable this option.

[1] 5a1b036
[2] web-platform-tests#10721
    @jugglinmike
    jugglinmike committed May 9, 2018
    Configuration menu
    Copy the full SHA
    597050f View commit details
    Browse the repository at this point in the history