Add run_info and timestamps to wptreport #10811
Conversation
Hexcles
force-pushed
the
more-info-in-wptreport
branch
from
80f6752
to
689cc7f
Compare
Hexcles
changed the title
| self.results = {} | ||
|
|
||
| def suite_start(self, data): | ||
| self.results['browser'] = data['run_info']['product'] |
There was a problem hiding this comment.
I would be tempted to just dump run_info directly into the results.
There was a problem hiding this comment.
Yeah let's do that.
Meanwhile, could you answer the question I had regarding these fields in run_info?
"linux_distro": "Debian",
"os": "linux",
"os_version": "sid",
"version": "Debian sid",
They seem to present an overlapping set of information. Is this intended? Notably, what's version? Is it intended to be the version of the product or the OS?
There was a problem hiding this comment.
All I know is what I can figure out from https://searchfox.org/mozilla-central/source/testing/mozbase/mozinfo/mozinfo/mozinfo.py. So version is what you get from uname and os_version has a more custom implementation.
There was a problem hiding this comment.
Alright, then I'll need to add a browser_version to run_info.
Just updated the PR to include the whole run_info. PTAL.
|
Since we're interested in building on this data from external projects, what do you think about documenting this format in the |
|
@jugglinmike First of all, I'm going to document some of the mandatory fields in my design doc, including the browser info and revision, which will solve the most pressing issue for uploading results. Later we can more formally document the whole wptreport here as a doc and/or JSON schema. |
run_info includes OS and browser info. This is the first stab at #10511 .
Hexcles
force-pushed
the
more-info-in-wptreport
branch
from
689cc7f
to
45278a9
Compare
Hexcles
changed the title
The first stab at #10511 , adding the simplest fields to make sure I understand correctly @jgraham
Meanwhile, how shall I pass the version of the browser? Via
run_info? FWIW, there'srun_info['version']which is the version of my OS (and it seems to overlap withrun_info['os_version']a bit).This change is