Teach the linter about // META: variant= #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
approved these changes
May 14, 2018
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 17, 2018
web-platform-tests/wpt#10985 changed lint.py and wpt-importer is now failing because of it: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17652 chromium.patch did not apply cleanly, so the changes had to be rebased on the new wpt version. This was much easier within the wpt repo itself, so the patch is changed to apply within the repo. Bug: 843799, 843945 Change-Id: I1ed9895b2461243c38fea552706960a3b99db2b6 Reviewed-on: https://chromium-review.googlesource.com/1061458 Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: Robert Ma <[email protected]> Cr-Commit-Position: refs/heads/master@{#559502}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is