Convert Input Events IDL test to use idl_test #12572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally and found to pass all 9 tests on Chrome, while Firefox fails 6 as this isn't implemented. So the tests now work. |
|
Uh, disregard the scroll-animations link given, I was working on multiple conversions and got them mixed up. This test was already working: |
foolip
force-pushed
the
idl-input-events
branch
from
e84a36f
to
83839d3
Compare
|
@foolip Can staging.wpt.fyi be used in a way to check what the test results are if a PR like this one is merged? Or should I be running this locally? |
|
@johanneswilm unfortunately there is no easy way to see what the results after a change are, even for those tests that do run on Travis currently. We're still working on #7475 to make this better. |
johanneswilm
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.