[cookies] Remove cookies when tests complete #12817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid test interactions by removing cookies at the completion of each test. Use the `add_cleanup` feature of testharness.js to ensure that this occurs regardless of the passing/failing status of each test. Persist the existing "setup" logic which defensively removes cookies as a precaution against still other tests which do not properly restore global state. This resolves a known instability caused by `cookies/prefix/__secure.document-cookie.https.html`. That test sets a cookie with a "Domain" attribute which `cookies/prefix/__secure.header.https.html` is not written to remove.
jdm
approved these changes
Sep 4, 2018
|
Looks totally reasonable to me, thank you for addressing it! |
|
Happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid test interactions by removing cookies at the completion of each
test. Use the
add_cleanupfeature of testharness.js to ensure thatthis occurs regardless of the passing/failing status of each test.
Persist the existing "setup" logic which defensively removes cookies as
a precaution against still other tests which do not properly restore
global state.
This resolves a known instability caused by
cookies/prefix/__secure.document-cookie.https.html. That test sets acookie with a "Domain" attribute which
cookies/prefix/__secure.header.https.htmlis not written to remove.