Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui] Inheritance and initial value #13095

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

ewilligers
Copy link
Contributor

Test that CSS Basic User Interface properties inherit.
Test that initial values match the spec.
https://drafts.csswg.org/css-ui/#property-index

@ewilligers
Copy link
Contributor Author

Edge gives 'invert' as the initial computed value for outline-color (consistent with spec) but Chrome/Firefox/Safari give rgb(...).

Edge does not support caret-color. No browser gives 'auto' as the initial computed value for caret-color (consistent with spec); Chrome/Firefox/Safari give rgb(...).

Only Chrome supports user-select.

@foolip
Copy link
Member

foolip commented Sep 20, 2018

The failing Travis build in this PR was due to #13112, which has now been resolved. To recover, rebase the PR on master and push. (Simply restarting the Travis jobs may also work, not tested.)

Test that CSS Basic User Interface properties inherit.
Test that initial values match the spec.
https://drafts.csswg.org/css-ui/#property-index
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewilligers
Copy link
Contributor Author

@svgeesus can you please merge this. GitHub tells me "Review required".

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossy review LGTM

@ewilligers ewilligers merged commit 2419900 into web-platform-tests:master Oct 25, 2018
@ewilligers ewilligers deleted the ui-inheritance branch October 25, 2018 08:22
@frivoal
Copy link
Contributor

frivoal commented Nov 1, 2018

Hmmm. Sorry for the slow review. I think we should actually revert / fix this:

  • For color properties, getComputedStyle returns the used value, not the computed value. They are different, but your asserts are written assuming the computed value. Hence why you get rgb(…) when you were expecting auto.
  • For the invert color of the outline-color property, you should check if the invert keyword is supported at all. If it is, it should be the initial value, but if it is not, having currentColor be the initial value is spec compliant, and should not cause the test to fail.

@frivoal
Copy link
Contributor

frivoal commented Nov 1, 2018

Just noticed you had filed a follow up in #13748 will continue discussing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants