-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-ui] Inheritance and initial value #13095
[css-ui] Inheritance and initial value #13095
Conversation
Edge gives 'invert' as the initial computed value for outline-color (consistent with spec) but Chrome/Firefox/Safari give rgb(...). Edge does not support caret-color. No browser gives 'auto' as the initial computed value for caret-color (consistent with spec); Chrome/Firefox/Safari give rgb(...). Only Chrome supports user-select. |
867f95f
to
3ba1f4c
Compare
The failing Travis build in this PR was due to #13112, which has now been resolved. To recover, rebase the PR on master and push. (Simply restarting the Travis jobs may also work, not tested.) |
Test that CSS Basic User Interface properties inherit. Test that initial values match the spec. https://drafts.csswg.org/css-ui/#property-index
3ba1f4c
to
058ff53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@svgeesus can you please merge this. GitHub tells me "Review required". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glossy review LGTM
Hmmm. Sorry for the slow review. I think we should actually revert / fix this:
|
Just noticed you had filed a follow up in #13748 will continue discussing there. |
Test that CSS Basic User Interface properties inherit.
Test that initial values match the spec.
https://drafts.csswg.org/css-ui/#property-index