Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Inheritance and initial values #13110

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

ewilligers
Copy link
Contributor

Test that CSS Text properties inherit.
Test that they have the initial values given in the spec.
https://drafts.csswg.org/css-text/#propdef-white-space

@foolip
Copy link
Member

foolip commented Sep 20, 2018

The failing Travis build in this PR was due to #13112, which has now been resolved. To recover, rebase the PR on master and push. (Simply restarting the Travis jobs may also work, not tested.)

Test that CSS Text properties inherit.
Test that they have the initial values given in the spec.
https://drafts.csswg.org/css-text/#propdef-white-space
@ewilligers
Copy link
Contributor Author

@frivoal Please review

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief review LGTM

@ewilligers ewilligers merged commit 1e37163 into web-platform-tests:master Oct 25, 2018
@ewilligers ewilligers deleted the text-inheritance branch October 25, 2018 08:21
@frivoal
Copy link
Contributor

frivoal commented Nov 1, 2018

LGTM too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants