Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Various test fixes for python3 support. (#11769)" #13248

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Revert "Various test fixes for python3 support. (#11769)" #13248

merged 1 commit into from
Sep 28, 2018

Conversation

gsnedders
Copy link
Member

This reverts commit 5bd512c.

Fixes #13204.

Ms2ger
Ms2ger previously requested changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that there are two open PRs that fix the issue, I don't see a point in reverting.

@jgraham
Copy link
Contributor

jgraham commented Sep 28, 2018

I agree that fixing this makes more sense than reverting.

@jgraham jgraham closed this Sep 28, 2018
@gsnedders
Copy link
Member Author

My goal here was simply to get these regressed tests working again ASAP, and then it avoids the urgency (of the currently both r-'d) fixes.

@gsnedders gsnedders mentioned this pull request Sep 28, 2018
Closed
@foolip foolip reopened this Sep 28, 2018
foolip
foolip approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per my thoughts in #13204 (comment), but will still require @Ms2ger to sign off. Still around?

@Ms2ger Ms2ger dismissed their stale review September 28, 2018 15:42

Anything's fine, as long as we end up with a real fix.

Hexcles
Hexcles approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like both attempted fixes have some non-trivial discussions. I agree with @gsnedders ; let's land the revert first.

@jgraham
Copy link
Contributor

jgraham commented Sep 28, 2018

Sorry, I hadn't realised that the other PRs had outstanding issues.

@foolip
Copy link
Member

foolip commented Sep 28, 2018

Thanks all, when Travis has finished on this one let's merge ASAP.

@Ms2ger @Hexcles would the best thing be to bake your two changes into a single PR?

@Hexcles
Copy link
Member

Hexcles commented Sep 28, 2018

@foolip yeah the duplicate work and bad timing were unfortunate. Once the discussions in the PRs clear up, we'll see how to best proceed.

@Hexcles Hexcles merged commit c757432 into web-platform-tests:master Sep 28, 2018
@gsnedders gsnedders deleted the revert-header-encoding-py3 branch September 28, 2018 16:14
@Hexcles Hexcles mentioned this pull request Sep 28, 2018
Merged
@foolip foolip mentioned this pull request Sep 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@Hexcles Hexcles Hexcles approved these changes

@Ms2ger Ms2ger Ms2ger left review comments

@jgraham jgraham Awaiting requested review from jgraham

Assignees
No one assigned
Labels
infra wptserve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gsnedders @jgraham @foolip @Hexcles @Ms2ger @wpt-pr-bot