[Background Fetch] Fix match() crash. #13603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 18, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1289269
branch
from
91bb640
to
76d55de
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1289269
branch
3 times, most recently
from
71c5101
to
bc8da74
Compare
Calling `match` was causing crashes in debug mode due to accessing base::Optional<>::value without initialization. Calling match with an unmatched request was crashing due to hitting a DCHECK. This returns undefined now as per the spec. Bug: 896768 Change-Id: I5d82e68ddca157a240ceaaec8990d2553366fbbb Reviewed-on: https://chromium-review.googlesource.com/c/1289269 Commit-Queue: Rayan Kanso <[email protected]> Reviewed-by: Peter Beverloo <[email protected]> Cr-Commit-Position: refs/heads/master@{#601541}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1289269
branch
from
bc8da74
to
f01a681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
matchwas causing crashes in debug mode due to accessingbase::Optional<>::value without initialization. Calling match with
an unmatched request was crashing due to hitting a DCHECK. This returns
undefined now as per the spec.
Bug: 896768
Change-Id: I5d82e68ddca157a240ceaaec8990d2553366fbbb
Reviewed-on: https://chromium-review.googlesource.com/c/1289269
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Peter Beverloo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#601541}