Ignore includers of untested mixins #13611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Oct 19, 2018
|
@lukebjerring, how risky is this, should we run it through Chromium bots once? |
|
It will definitely remove a number of tests, and might not be correct, so yes let's do a chromium run. (Can you do it for me? I don't have chromium on my laptop yet..) |
|
How did it go? |
|
Nobody started a run, miscommunication :) |
|
Is there still plan to start a run or do we merge this and see how it goes? |
|
Luke was asking you to do a run. What you have to do is copy over the changes to a throwaway Chromium CL and do a CQ dry run. |
|
/me feel stupid Here's the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1303727 |
|
@foolip All bots are green.
|
|
Thanks @beaufortfrancois , I'll merge this based on the green-ness. |
|
Sweet, thanks @beaufortfrancois! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #13598
Specific example:
Window includes WindowOrWorkerGlobalScope, as doesWorkerGlobalScope, but we don't need to testWorkerGlobalScope.