Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expectations for Safari in for infrastructure/ tests #13638

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 20, 2018

In preparation for running these tests in CI.

Verified locally with Safari Technology Preview 67:

export no_proxy='*'
./wpt run --metadata infrastructure/metadata/ --channel=preview safari infrastructure/
./wpt run --metadata infrastructure/metadata/ --channel=preview safari_webdriver infrastructure/

With Safari 12 there are still failures, but we'll not use that in CI.

In preparation for running these tests in CI.

Verified locally with Safari Technology Preview 67:
```
export no_proxy='*'
./wpt run --metadata infrastructure/metadata/ --channel=preview safari infrastructure/
./wpt run --metadata infrastructure/metadata/ --channel=preview safari_webdriver infrastructure/
```

With Safari 12 there are still failures, but we'll not use that in CI.
@foolip
Copy link
Member Author

foolip commented Oct 20, 2018

Note that https://bugs.webkit.org/show_bug.cgi?id=190775 is newly filed for this PR.

@foolip foolip requested a review from youennf October 20, 2018 20:25
@gsnedders
Copy link
Member

It would be nice to have this working with Safari 12 too, but I expect it's not really worthwhile; what are the extra failures there?

@foolip
Copy link
Member Author

foolip commented Oct 21, 2018

I didn't check too closely, some service worker tests I think. If it's possible to use the browser version as part of the condition I could set it up, but is it? Then it's depend on my PR to get the version...

@Ms2ger Ms2ger merged commit 40e9266 into master Oct 22, 2018
@Ms2ger Ms2ger deleted the foolip/safari-infrastructure-metadata branch October 22, 2018 12:06
@foolip
Copy link
Member Author

foolip commented Oct 22, 2018

No merge_pr_13638 tag was created for this because https://travis-ci.org/web-platform-tests/wpt/jobs/444636306 failed, which is because the GitHub API doesn't realize that commit 40e9266 is for this PR. Given the timing I assume it's because of https://blog.github.com/2018-10-21-october21-incident-report/ so I've manually pushed the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants