Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for supportedTypes from basic-card #13859

Merged
merged 4 commits into from
Nov 2, 2018
Merged

Remove tests for supportedTypes from basic-card #13859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dfc134
Remove tests for supportedTypes from basic-card
Nov 1, 2018
79f4a1b
Add historical check for supportedType
Nov 1, 2018
a6311d7
Update payment-method-basic-card/empty-data-manual.https.html
rsolomakhin Nov 1, 2018
c6c2557
Update payment-method-basic-card/empty-data-manual.https.html
rsolomakhin Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions payment-method-basic-card/empty-data-manual.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ <h2>
The test expects the following credit card.
</p>
<ol>
<li>Add credit card:
<li>Add card:
<dl>
<dt>Cardholder name:</dt>
<dd>web platform test</dd>
Expand Down Expand Up @@ -112,22 +112,12 @@ <h2>
<ol>
<li>
<button onclick="runPromiseTest(this, {});">
When passed BasicCardRequest without members, allow the user to input of any credit card type.
</button>
</li>
<li>
<button onclick="runPromiseTest(this, { supportedNetworks: [], supportedTypes: [] });">
Returns any card type on any network, because zero length supportedNetworks and supportedTypes.
When passed BasicCardRequest without members, allow the user to input a card on any network.
</button>
</li>
<li>
<button onclick="runPromiseTest(this, { supportedNetworks: [] });">
Returns any card type on any network, because supportedNetworks is missing and supportedTypes is empty.
</button>
</li>
<li>
<button onclick="runPromiseTest(this, { supportedTypes: [] });">
Returns any card type on any network missing supportedTypes, and empty supportedNetwork.
Returns a card on any network, because zero length supportedNetworks.
</button>
</li>
</ol>
Expand Down
25 changes: 25 additions & 0 deletions payment-method-basic-card/historical.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!doctype html>
<meta charset=utf-8>
<title>Historical Basic Card Changes</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script>
// https://github.com/w3c/payment-method-basic-card/pull/62
test(() => {
try {
new PaymentRequest(
[
{
supportedMethods: "basic-card",
supportedTypes: [
"this was an enum value once - so this would have thrown",
],
},
],
{ total: { label: "bar", amount: { currency: "BAZ", value: "0" } } }
);
} catch (err) {
assert_unreached("Unexpected error");
}
}, "supportedTypes and BasicCardType enum were removed from the spec");
</script>