-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for AudioContext to enable generating audio tracks with it #13869
Check for AudioContext to enable generating audio tracks with it #13869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to make explicit that this way is only supposed to be used on standards-compliant WebAudio.
@nils-ohlmeier can you figure out what failed on Firefox? (if it still fails) |
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Locally the tests them self appear to work fine with and without this change. But the logs collected here are way to verbose. And they reach the defined max output, so we can't see what actually happens at the end. But I'm failing to locate where the logs strings are set for WTP. Which WPT expert might be able to help locating that? |
I defer to @jgraham on that. |
OK, let's go with this PR then. I do not think this change should change much in Firefox. |
FWIW, I think there is some flakiness in Firefox bot since Firefox is defining AudioContext and so this change should be a no op. |
WebKit exposes webkitAudioContext which is slightly different from AudioContext.
For WebRTC tests, it is simpler to rely on getUserMedia tests with mock active.