Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options #13893

Merged
merged 2 commits into from
Nov 4, 2018

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 4, 2018

No description provided.

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that generateOffer() is only used to generate data channel offers!
Short helpers are good helpers.

webrtc/idlharness.https.window.js Outdated Show resolved Hide resolved
@youennf
Copy link
Contributor Author

youennf commented Nov 4, 2018

Firefox bot issue is probably unrelated, merging.

@youennf youennf merged commit cd17e3b into web-platform-tests:master Nov 4, 2018
youennf added a commit to youennf/web-platform-tests that referenced this pull request Nov 4, 2018
youennf added a commit to youennf/web-platform-tests that referenced this pull request Nov 4, 2018
youennf added a commit to youennf/web-platform-tests that referenced this pull request Nov 4, 2018
youennf added a commit that referenced this pull request Nov 4, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 14, 2018
…rm-tests/wpt#13893, a=testonly

Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908)

--

wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564
wpt-pr: 13908
staktrace pushed a commit to staktrace/gecko that referenced this pull request Nov 15, 2018
…rm-tests/wpt#13893, a=testonly

Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908)

--

wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564
wpt-pr: 13908
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…rm-tests/wpt#13893, a=testonly

Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908)

--

wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564
wpt-pr: 13908

UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…rm-tests/wpt#13893, a=testonly

Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908)

--

wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564
wpt-pr: 13908

UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…rm-tests/wpt#13893, a=testonly

Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908)

--

wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564
wpt-pr: 13908

UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants