Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RTCRtpTransceiver tests related to OfferToReceive legacy options to webrtc/legacy #13903

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Move RTCRtpTransceiver tests related to OfferToReceive legacy options to webrtc/legacy #13903

merged 1 commit into from
Nov 4, 2018

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 4, 2018

No description provided.

alvestrand
alvestrand approved these changes Nov 4, 2018
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the shape of these tests, but it doesn't seem unreasonable to segregate these.

@youennf
Copy link
Contributor Author

youennf commented Nov 4, 2018

I don't love the shape of these tests, but it doesn't seem unreasonable to segregate these.

Agreed, and I did not want to touch these in this patch :)
Some of these tests might be redundant with other webrtc/legacy tests.
If we want to do some clean-up there, it would best be done as a follow-up.

@youennf youennf merged commit 72fa5dd into web-platform-tests:master Nov 4, 2018
@jugglinmike jugglinmike mentioned this pull request Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand approved these changes

@agouaillard agouaillard Awaiting requested review from agouaillard

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@guidou guidou Awaiting requested review from guidou

@henbos henbos Awaiting requested review from henbos

@phoglund phoglund Awaiting requested review from phoglund

@rwaldron rwaldron Awaiting requested review from rwaldron

@snuggs snuggs Awaiting requested review from snuggs

Assignees
No one assigned
Labels
webrtc wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youennf @alvestrand @wpt-pr-bot