Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded setting of onaddstream #13904

Merged
merged 2 commits into from
Nov 4, 2018
Merged

Remove unneeded setting of onaddstream #13904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8da49cd
Remove unneeded setting of onaddstream
youennf Nov 4, 2018
92297ec
Remove unused onRemoteStream
youennf Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions webrtc/getstats.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ <h2>Retrieved stats info</h2>
}
});

var onRemoteStream = test.step_func(function(event) {
assert_unreached('WebRTC received a stream when there was none');
});

var getStatsRecordByType = function(stats, type) {
for (let stat of stats.values()) {
if (stat.type == type) {
Expand Down Expand Up @@ -91,7 +87,6 @@ <h2>Retrieved stats info</h2>

gSecondConnection = new RTCPeerConnection(null);
gSecondConnection.onicecandidate = onIceCandidateToSecond;
youennf marked this conversation as resolved.
Show resolved Hide resolved
gSecondConnection.onaddstream = onRemoteStream;

// The createDataChannel is necessary and sufficient to make
// sure the ICE connection be attempted.
Expand Down