Perform safe addIceCandidate together with signaling handshake #13906
Conversation
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
guidou,
henbos,
phoglund,
rwaldron,
snuggs and
youennf
|
stability checker failing https://travis-ci.org/web-platform-tests/wpt/jobs/450421135 |
soareschen
force-pushed
the
safe-add-icecandidate
branch
from
1937a04
to
52b2344
Compare
soareschen
force-pushed
the
safe-add-icecandidate
branch
from
52b2344
to
c198b91
Compare
|
@soareschen seems we have conflicts again |
soareschen
force-pushed
the
safe-add-icecandidate
branch
from
c198b91
to
0612de1
Compare
|
Rebased now. Will merge if there is no more comment. |
soareschen
force-pushed
the
safe-add-icecandidate
branch
from
0612de1
to
81b9916
Compare
|
Not sure why but the Taskcluster check failure is preventing this PR from getting merged. |
|
Because the Firefox and Chrome stability jobs are failing, which implies that the tests are flaky in CI. See the logs at [1] [2]. [1] https://taskcluster-artifacts.net/ccHuAqwYRCWwtTC8P9hCqA/0/public/logs/live_backing.log |
| // Helper function to exchange ice candidates between two local peer connections. | ||
| // Accepts an optional handshakePromise to wait for setRemoteDescription() to be | ||
| // done before calling addIceCandidate(). | ||
| function exchangeIceCandidates(pc1, pc2, handshakePromise) { |
There was a problem hiding this comment.
I don't think we should land this. This is queuing ICE candidates again, like in #14417 (comment).
It also doesn't appear to fix the problem.
As long as people call exchangeIceCandidates(pc1, pc2) before doSignalingHandshake(pc1, pc2) there should be no race. Let's discuss in #12028 (comment).
|
This PR is blocked on the required "Travis CI - Pull Request" check after #14499. There are also conflicts, so resolving those by rebasing the PR will cause the new Travis CI check to run. |
|
@jan-ivar I think you fixed that a couple of years back so this is obsolete? |
Fixes #12028.
Note that not all usage of
exchangeIceCandidates()is replaced. The remaining should be fixed in another PR.