Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions introduced in https://github.com/web-platform-tests/wpt/pull/13893 #13908

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Fix regressions introduced in https://github.com/web-platform-tests/wpt/pull/13893 #13908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webrtc/RTCPeerConnection-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ function assert_session_desc_not_similar(sessionDesc1, sessionDesc2) {

async function generateDataChannelOffer(pc) {
pc.createDataChannel('test');
const offer = pc.createOffer();
assert_equals(countApplicationLine(sdp), 1, 'Expect m=application line to be present in generated SDP');
const offer = await pc.createOffer();
assert_equals(countApplicationLine(offer.sdp), 1, 'Expect m=application line to be present in generated SDP');
return offer;
}

Expand Down Expand Up @@ -135,7 +135,7 @@ async function generateVideoReceiveOnlyOffer(pc)
async function generateAnswer(offer) {
const pc = new RTCPeerConnection();
await pc.setRemoteDescription(offer);
const answer = pc.createAnswer();
const answer = await pc.createAnswer();
pc.close();
return answer;
}
Expand Down