[Gecko Bug 1457129] Correct WebRTC getStats WPT to wait for remote stats before comparing #13942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If care is not taken to wait for remote stats on senders and receivers, then the contents of the stats reports will not be stable. Waiting for this stability should fix our intermittent failures checking that RTCRtpSender/Receiver.getStats() returns the same dictionaries that RTCPeerConnection.getStats(sender/receiver.track) does. Differential Revision: https://phabricator.services.mozilla.com/D5804 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1457129 gecko-commit: 0874b793fc046bf31ca80c673d5dfa0bb38ea343 gecko-integration-branch: autoland gecko-reviewers: jib
wpt-pr-bot
approved these changes
Nov 6, 2018
|
w3c-test:mirror |
|
This seems to be unstable in gecko. Since it landed in m-c I'm minded to merge the PR anyway, but it would be good to understand what's going on here (due to the amount of output, the taskcluster stability job — which is currently set to always succeed — has the more useful information on what was unstable). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If care is not taken to wait for remote stats on senders and receivers, then the contents
of the stats reports will not be stable. Waiting for this stability should fix our
intermittent failures checking that RTCRtpSender/Receiver.getStats() returns the
same dictionaries that RTCPeerConnection.getStats(sender/receiver.track) does.
Differential Revision: https://phabricator.services.mozilla.com/D5804
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1457129
gecko-commit: 0874b793fc046bf31ca80c673d5dfa0bb38ea343
gecko-integration-branch: autoland
gecko-reviewers: jib