Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test_driver.bless to work when running manually #14073

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 15, 2018

Tests using test_driver.bless now currently always fail when running
them manually, because the default test_driver_internal.click
rejects with "unimplemented".

Mute the rejection if the session isn't controlled by WebDriver, which
we check with navigator.webdriver.

Tests using `test_driver.bless` now currently always fail when running
them manually, because the default `test_driver_internal.click`
rejects with "unimplemented".

Mute the rejection if the session isn't controlled by WebDriver, which
we check with `navigator.webdriver`.
@foolip
Copy link
Member Author

foolip commented Nov 15, 2018

This is an alternative to #11173, and only fixes test_driver.bless.

@jgraham
Copy link
Contributor

jgraham commented Nov 15, 2018

I'm somewhat concerned about the use of the webdriver property here; although it's possibly fine it's unclear how future-proof it is to assume that all automation is webdriver-driven.

@foolip
Copy link
Member Author

foolip commented Nov 15, 2018

I'd be happy to use any other signal we have that we're being controlled by wptrunner. Do we have something else we could use?

@jugglinmike
Copy link
Contributor

@foolip
Copy link
Member Author

foolip commented Nov 16, 2018

The answer is straightforward I think: use navigator.webdriver, add a test to /infrastructure/assumptions/ for it, and refine if there's a problem. The consequence of getting it wrong is just to change the failure mode from fast fail to timeout.

@gsnedders
Copy link
Member

@foolip does this work for run-webkit-tests and Marionette and CDP and other non-WebDriver runners?

@foolip
Copy link
Member Author

foolip commented Nov 16, 2018

@gsnedders, no, but there we'll replace test_driver_internal.click anyway. (Moving this sort of thing into test_driver_internal.* might make sense.)

@foolip
Copy link
Member Author

foolip commented Nov 23, 2018

@jugglinmike, do you intend to get #11173 landed? If that's not imminent I'd like to land something simple like this PR that makes manual testing possible.

@jugglinmike
Copy link
Contributor

I'd like to land gh-11173. I've just updated it in an attempt to satisfy the remaining concerns.

@foolip
Copy link
Member Author

foolip commented Nov 24, 2018

All right, reviewing that.

@foolip foolip closed this Nov 24, 2018
@foolip foolip deleted the foolip/manual-bless branch November 24, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants