Replace general source type with none source type #14081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the web driver spec the general source type string should be "none". https://w3c.github.io/webdriver/#input-source-state
|
Please add a test e.g. Author: James Graham <[email protected]>
Date: Mon Nov 19 16:31:36 2018 +0000
Add a test for the pause action
diff --git a/infrastructure/testdriver/actions/pause.html b/infrastructure/testdriver/actions/pause.html
new file mode 100644
index 0000000000..62a631130b
--- /dev/null
+++ b/infrastructure/testdriver/actions/pause.html
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>TestDriver actions: event order</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/resources/testdriver.js"></script>
+<script src="/resources/testdriver-actions.js"></script>
+<script src="/resources/testdriver-vendor.js"></script>
+
+<script>
+async_test(t => {
+ let t0 = performance.now();
+ let actions = new test_driver.Actions()
+ .addTick(2000)
+ .send()
+ .then(t.step_func_done(() => assert_greater_than(performance.now() - t0, 2000)));
+})
+</script> |
jgraham
approved these changes
Nov 19, 2018
jugglinmike
requested changes
Nov 19, 2018
| let actions = new test_driver.Actions() | ||
| .addTick(2000) | ||
| .send() | ||
| .then(t.step_func_done(() => assert_greater_than(performance.now() - t0, 2000))); |
There was a problem hiding this comment.
This test will time out instead of fail if the promise is rejected. Could you add a rejection handler or refactor it into a promise_test?
| @@ -0,0 +1,18 @@ | |||
| <!DOCTYPE html> | |||
| <meta charset="utf-8"> | |||
| <title>TestDriver actions: event order</title> | |||
There was a problem hiding this comment.
Mind updating the title?
There was a problem hiding this comment.
Sure. I will also need to skip the test for Chrome as we don't support it yet in ChromeDriver.
|
@jugglinmike are you happy with this PR now with the recent changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the web driver spec the general source type
string should be "none".
https://w3c.github.io/webdriver/#input-source-state