[UserTimingL3] Fix meature, mark API feature detection #14084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 15, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1338225
branch
2 times, most recently
from
7e846df
to
6f4783e
Compare
UserTimingL3 uses returned value for feature detection. If measure and mark API returns null, the APIs are L2 API; If the APIs return an entry, the APIs are L3 API. However, in the current implementation, when L3 API is enabled, the APIs do not always return the created entry. This CL is to fix this bug, and add layout tests to verify it. Change-Id: I9854f0abd0d64a3334701e09d6ce0fc245fcca3e Reviewed-on: https://chromium-review.googlesource.com/c/1338225 Commit-Queue: Liquan (Max) Gǔ <[email protected]> Reviewed-by: Nicolás Peña Moreno <[email protected]> Cr-Commit-Position: refs/heads/master@{#608552}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1338225
branch
from
6f4783e
to
d38540d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserTimingL3 uses returned value for feature detection. If measure and mark
API returns null, the APIs are L2 API; If the APIs return an entry, the APIs are
L3 API. However, in the current implementation, when L3 API is enabled, the
APIs do not always return the created entry.
This CL is to fix this bug, and add layout tests to verify it.
Change-Id: I9854f0abd0d64a3334701e09d6ce0fc245fcca3e
Reviewed-on: https://chromium-review.googlesource.com/c/1338225
Commit-Queue: Liquan (Max) Gǔ <[email protected]>
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/heads/master@{#608552}