Remove timout in async_test for websockets tests #14088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Nov 16, 2018
qiuzhong
force-pushed
the
remove-timeout-websockets
branch
from
ac0809e
to
b37b12d
Compare
Remove all the timeout in async_test for websockets tests. Affected tests: 21 Before: Pass: 6, Failed: 15 After: Pass: 6, Failed: 15 Related: web-platform-tests#11120
The `null` and `undefined` are placeholders for the `property` argument. They'll be no use when the `property` is removed from `async_test` and should be removed.
|
@foolip , the taskcluster got stuck. This happened quite often recently. Do you know what's going on? |
|
Before/after diff view of these changes: Looks like no regressions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the timeout in async_test for websockets tests.
Affected tests: 21
Before: Pass: 6, Failed: 15
After: Pass: 6, Failed: 15
Related: #11120