Remove timeout in async_test for mediacapture-streams tests #14089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
eric-carlson,
jan-ivar and
youennf
qiuzhong
force-pushed
the
remove-timeout-mediacapture-streams
branch
from
1bb976f
to
81c52db
Compare
Remove all the timeout in `async_test` for mediacapture-streams tests. Affected tests: 12 Before: Pass: 10, Failed: 2 After: Pass: 10, Failed: 2 Related: web-platform-tests#11120
foolip
reviewed
Nov 22, 2018
| @@ -15,7 +15,7 @@ <h1 class="instructions">Description</h1> | |||
| <script src=/resources/testharness.js></script> | |||
| <script src=/resources/testharnessreport.js></script> | |||
| <script> | |||
| var t = async_test("Tests that adding a track to a MediaStream works as expected", {timeout: 20000}); // longer timeout since requires double user interaction | |||
| var t = async_test("Tests that adding a track to a MediaStream works as expected"); // longer timeout since requires double user interaction | |||
There was a problem hiding this comment.
Can you remove the comment which refers to the deleted code?
There was a problem hiding this comment.
Oops! Most of the update was done by a script and I didn't notice that useless comment. It's removed now.
| @@ -17,7 +17,7 @@ <h1 class="instructions">Description</h1> | |||
| <script src=/resources/testharness.js></script> | |||
| <script src=/resources/testharnessreport.js></script> | |||
| <script> | |||
| var t = async_test("Tests that the video MediaStreamTrack objects are properly ended on permission revocation", {timeout: 20000}); // longer timeout since requires user interaction | |||
| var t = async_test("Tests that the video MediaStreamTrack objects are properly ended on permission revocation"); // longer timeout since requires user interaction | |||
Since the `timeout` is removed from `async_test`, the comments are useless and should be removed.
foolip
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the timeout in
async_testfor mediacapture-streams tests.Affected tests: 12
Before: Pass: 10, Failed: 2
After: Pass: 10, Failed: 2
Related: #11120