Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stability-checker failures on Travis and report them on Taskcluster #14096

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Allow stability-checker failures on Travis and report them on Taskcluster #14096

merged 4 commits into from
Nov 16, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 16, 2018

Fixes #7660.

#13194 remains open to
verify that Taskcluster isn't failing to detect flakiness that Travis
would.

@foolip
Make stability checks on Travis blocking and on Travis not
1f6ab50 
Fixes #7660.

#13194 remains open to
verify that Taskcluster isn't failing to detect flakiness that Travis
would.
This was referenced Nov 16, 2018
Merged
Merged
@foolip
Copy link
Member Author

foolip commented Nov 16, 2018

I didn't get the Travis change right, trying again...

@sideshowbarker sideshowbarker changed the title Make stability checks on Travis blocking and on Travis not Make stability checks on Taskcluster blocking and on Travis not Nov 16, 2018
@foolip
Copy link
Member Author

foolip commented Nov 16, 2018

Alright, I appear to have succeeded! Review please :)

@Ms2ger Ms2ger changed the title Make stability checks on Taskcluster blocking and on Travis not Allow stability-checker failures on Travis and report them on Taskcluster Nov 16, 2018
Ms2ger
Ms2ger approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message and remove the flaky test before landing :)

@foolip foolip mentioned this pull request Nov 16, 2018
Closed
@foolip foolip merged commit bcd2471 into master Nov 16, 2018
@foolip foolip deleted the foolip/stability-taskcluster-block-travis-not branch November 16, 2018 17:03
@foolip
Copy link
Member Author

foolip commented Nov 16, 2018

Alright, merged, I feel like celebrating on such a great Friday. I'll make Taskcluster a required check, that's plenty celebratory.

This was referenced Nov 16, 2018
Closed
Merged
@jugglinmike

This comment has been minimized.

Sign in to view
@jugglinmike
Copy link
Contributor

Arg, I posted to the wrong thread. My previous message was intended for gh-13194. I'll repost there. Sorry for the confusion!

@jugglinmike jugglinmike mentioned this pull request Nov 16, 2018
Closed
@foolip foolip mentioned this pull request Nov 21, 2018
Closed
@jugglinmike jugglinmike mentioned this pull request Dec 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@jgraham jgraham jgraham approved these changes

Assignees
No one assigned
Labels
infra old-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foolip @jugglinmike @Ms2ger @jgraham @wpt-pr-bot