-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test exclusion logic of wpt/referrer-policy test generator #14131
Conversation
Previously, all worker-request, a-tag, area-tag tests were excluded because "redirection" field was not included in |selection_pattern|, and thus "worker-requests-with-swap-origin-redirect" and "overhead-for-redirection" entries in "excluded_tests" in spec.src.json were applied to all redirection types. This CL - Includes "redirection" field in |selection_pattern| and instead remove "redirection" field from filenames, and - Regenerates tests. Therefore, this CL - Adds new test files for worker-request, a-tag, area-tag, and - Renames existing test files. The only manual changes are - referrer-policy/generic/tools/common_paths.py - third_party/WebKit/LayoutTests/SlowTests - third_party/WebKit/LayoutTests/SmokeTests and all other modifications are made by referrer-policy/generic/tools/generate.py. Bug: 880027 Change-Id: Ie628f92b334d6e2adddc5957cc6cceaa8c69f322 Reviewed-on: https://chromium-review.googlesource.com/c/1330901 Reviewed-by: Hiroki Nakagawa <[email protected]> Reviewed-by: Jochen Eisinger <[email protected]> Reviewed-by: Dirk Pranke <[email protected]> Commit-Queue: Hiroshige Hayashizaki <[email protected]> Cr-Commit-Position: refs/heads/master@{#609433} warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
@Hexcles as much as I love the PR title, you should probably handle this better |
Yikes... |
@jugglinmike Taskcluster failed:
Any idea what went wrong? Is this change too large? |
The patch does modify a lot of files. The final command in the following script required about 10 minutes to complete on my system:
So while I can't reproduce the failure here, I suspect the script is crashing due to system memory limitations. We can probably make the script more resilient (or maybe just stream the file names as they are discovered), but note that the subsequent stability check would certainly time out. |
Thanks for the explanation, Mike. Let me admin-merge this PR. I double checked the original CL in Chromium and it's mostly just pure renaming. Chromium CI also passed without a hitch, so I have pretty high confidence. |
Also filed https://crbug.com/907118 for the funny title. |
Previously, all worker-request, a-tag, area-tag tests were excluded
because "redirection" field was not included in |selection_pattern|,
and thus "worker-requests-with-swap-origin-redirect" and
"overhead-for-redirection" entries in "excluded_tests" in spec.src.json
were applied to all redirection types.
This CL
instead remove "redirection" field from filenames, and
Therefore, this CL
The only manual changes are
and all other modifications are made by
referrer-policy/generic/tools/generate.py.
Bug: 880027
Change-Id: Ie628f92b334d6e2adddc5957cc6cceaa8c69f322
Reviewed-on: https://chromium-review.googlesource.com/c/1330901
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/master@{#609433}
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command.