Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Pipelines] Run infrastructure/ tests on Windows 10 #14300

Merged
merged 138 commits into from
Jan 31, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 29, 2018

No description provided.

@foolip
Copy link
Member Author

foolip commented Nov 30, 2018

Getting Python installed is the first challenge. I've tried msiexec /a python-2.7.15.amd64.msi but it fails with "The Windows Installer Service could not be accessed. This can occur if the Windows Installer is not correctly installed. Contact your support personnel for assistance." @thejohnjansen do you know the best way to install stuff? Does the context where the Azure Pipelines steps are run have administrator rights, or some equivalent of sudo rights?

@foolip
Copy link
Member Author

foolip commented Dec 20, 2018

This is ready for real review now. @gsnedders?

foolip added a commit that referenced this pull request Dec 21, 2018
@foolip foolip changed the title [Azure Pipelines] Run infrastructure/ tests on Windows 10 Insider Preview [Azure Pipelines] Run infrastructure/ tests on Windows 10 Jan 24, 2019
@foolip
Copy link
Member Author

foolip commented Jan 24, 2019

After discussion with @thejohnjansen, renaming to focus on Windows 10 stable and not Insider Preview.

inputs:
artifactName: 'infrastructure'
condition: succeededOrFailed()
- powershell: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not in a YML file like the hosts update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this bit, hoping to not need it when this is merged. That's blocked on the agent pool being reliably populated with responsive agents that don't get their state messed up so easily.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else is this waiting on now? You've got the review you asked for now. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll write email about the agent pool.

@foolip
Copy link
Member Author

foolip commented Jan 30, 2019

@gsnedders this is now failing only because /infrastructure/reftest/size.html fails. I'll file a bug and mark that as an expected failure.

@foolip
Copy link
Member Author

foolip commented Jan 30, 2019

I've made some final touched and made this a manually triggered job to make it possible to land and build on.

https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5369 is the build triggered automatically by this PR running macOS, and https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5368 is a manually triggered build from this branch showing that the Windows 10 job works.

@foolip
Copy link
Member Author

foolip commented Jan 30, 2019

@gsnedders this is ready for final review or even merging (squashing!) now.

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash!

@foolip foolip merged commit b5e0013 into master Jan 31, 2019
@foolip foolip deleted the foolip/azure-win10 branch January 31, 2019 12:44
@foolip
Copy link
Member Author

foolip commented Jan 31, 2019

Squahed! Thanks @Ms2ger!

@foolip
Copy link
Member Author

foolip commented Jan 31, 2019

https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5517 is a manually triggered build from master after merging this showing that it works, so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants