-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Pipelines] Run infrastructure/ tests on Windows 10 #14300
Conversation
268ea0d
to
3922f25
Compare
Getting Python installed is the first challenge. I've tried |
This reverts commit 77166f4.
This is ready for real review now. @gsnedders? |
After discussion with @thejohnjansen, renaming to focus on Windows 10 stable and not Insider Preview. |
.azure-pipelines.yml
Outdated
inputs: | ||
artifactName: 'infrastructure' | ||
condition: succeededOrFailed() | ||
- powershell: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not in a YML file like the hosts update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this bit, hoping to not need it when this is merged. That's blocked on the agent pool being reliably populated with responsive agents that don't get their state messed up so easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else is this waiting on now? You've got the review you asked for now. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll write email about the agent pool.
@gsnedders this is now failing only because /infrastructure/reftest/size.html fails. I'll file a bug and mark that as an expected failure. |
I've made some final touched and made this a manually triggered job to make it possible to land and build on. https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5369 is the build triggered automatically by this PR running macOS, and https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5368 is a manually triggered build from this branch showing that the Windows 10 job works. |
@gsnedders this is ready for final review or even merging (squashing!) now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash!
Squahed! Thanks @Ms2ger! |
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=5517 is a manually triggered build from master after merging this showing that it works, so far. |
No description provided.